This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 0/6] Move gdbsupport to top level
On 2020-01-11 11:58 a.m., Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> Here is an update of the series to move gdbsupport to the top level.
> Tom> This is one step in the bigger projecct to move gdbserver to top
> Tom> level.
>
> I see that patches #2 and #3 did not come through.
> I think they ran into the size limit.
>
> Here is patch 2. I'll send patch 3 separately.
> Using "git show" makes patch 2 smaller, but I'm also going to edit out
> the generated files from both patches.
The indentation in common.m4 looks off, starting with:
AC_CACHE_CHECK([for sigsetjmp], gdb_cv_func_sigsetjmp
Starting from this line until the end, I think it should be indented by
two columns. It's already wrong today, but what you added also has wrong
indentation, making it hard to understand that it's all under `GDB_AC_COMMON`.
Could you fix that? I don't really mind if it's a patch before or after this
series.
I see that GDB_AC_PTRACE is called in all three configure.ac files. Should it
be put in GDB_AC_COMMON?
Other than that, the series LGTM.
Simon