This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic


> I read through the series.
> 
> I think this warning would be good to have, because it can help detect
> bugs.

A small bonus is that this warning should also help us detect functions
that could be declared static. Not a huge deal in terms of code
correctness, but a valuable piece of information, when one is
reading through the code...

> It's maybe mildly unfortunate that we have to have the first
> patch, but at the same time it's not that much noise in the end -- just
> an extra line (typically) near the end of a file.  The other patches all
> seem desirable on their own terms.
> 
> So, I think you should check it in.

+1

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]