This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Simon Marchi <simon dot marchi at efficios dot com>, gdb-patches at sourceware dot org
- Date: Sun, 12 Jan 2020 11:06:46 +0400
- Subject: Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic
- References: <20200110220027.26450-1-simon.marchi@efficios.com> <87d0bqexxj.fsf@tromey.com>
> I read through the series.
>
> I think this warning would be good to have, because it can help detect
> bugs.
A small bonus is that this warning should also help us detect functions
that could be declared static. Not a huge deal in terms of code
correctness, but a valuable piece of information, when one is
reading through the code...
> It's maybe mildly unfortunate that we have to have the first
> patch, but at the same time it's not that much noise in the end -- just
> an extra line (typically) near the end of a file. The other patches all
> seem desirable on their own terms.
>
> So, I think you should check it in.
+1
--
Joel