This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Gerrit can receive and parse emails now


On Thursday, October 24 2019, Eli Zaretskii wrote:

>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>> Date: Wed, 23 Oct 2019 18:08:49 -0400
>> 
>> Another thing to notice is that we should only reply to the email in the
>> Reply-To field.
>
> This is a problem for me, because that header is not shown by default
> (it's not usually interesting), so I cannot easily verify that the
> response fulfills this requirement.
>
> Is there anything that can be done to avoid message duplication,
> without browsing the full email headers?  E.g., are there some rules
> Gerrit uses regarding the order of the addresses that I could observe
> manually?

I just discovered another limitation: gerrit apparently doesn't know how
to parse email replies to new change notifications.  That's why when a
change is created, the Reply-To header won't contain the "correct" email
address (which, in our case, would be "gnutoolchain-gerrit@osci.io").
It will instead contain the addresses of the "interested parties".

For example, Christian's last change:

  https://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2019-10&msgid=gerrit.1571943186000.I75f1b873562bc2abc6f2db17699a3e82fcfd2de3%40gnutoolchain-gerrit.osci.io

Contains:

  Reply-To: cbiesinger at google dot com, cbiesinger at google dot com, gdb-patches at sourceware dot org

Which is really not what I was expecting.  However, when a comment is
made, it does contain the "correct" Reply-To:

  https://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2019-10&msgid=20191024185557.547FE204C9%40gnutoolchain-gerrit.osci.io

So yeah, if you want to comment on a change, you will still need to open
your browser.

As for your request, something that perhaps could be done is to send the
notification emails using "Bcc" instead of "To".  If we Bcc all the
emails and set Reply-To accordingly, I think it can improve this
situation.  We haven't been able to make this work, though.  I think
sourceware has some sort of policy that prevents Bcc'ed emails, maybe?
I'll look into it.

BTW, before I forget: maybe this is obvious, but in order to reply to a
comment via email you need to have a user registered on gerrit.  It
won't accept comments from non-registered users (which is good,
actually).

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]