This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed] Remove python_has_threads check in configure.ac
- From: "Sourceware to Gerrit sync (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Christian Biesinger <cbiesinger at google dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Thu, 24 Oct 2019 15:15:07 -0400
- Subject: [pushed] Remove python_has_threads check in configure.ac
- Auto-submitted: auto-generated
- References: <gerrit.1571943186000.I75f1b873562bc2abc6f2db17699a3e82fcfd2de3@gnutoolchain-gerrit.osci.io>
- Reply-to: noreply at gnutoolchain-gerrit dot osci dot io, simon dot marchi at polymtl dot ca, cbiesinger at google dot com, gdb-patches at sourceware dot org
The original change was created by Christian Biesinger.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/301
......................................................................
Remove python_has_threads check in configure.ac
The only use of python_has_threads has been removed in
commit 404f29021abaef86a341663444fb069eb1f0282a
gdb/ChangeLog:
2019-10-24 Christian Biesinger <cbiesinger@google.com>
* configure: Rebuild.
* configure.ac: Remove code that sets python_has_threads.
Change-Id: I75f1b873562bc2abc6f2db17699a3e82fcfd2de3
---
M gdb/ChangeLog
M gdb/configure
M gdb/configure.ac
3 files changed, 5 insertions(+), 45 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0545f4a..664000a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-10-24 Christian Biesinger <cbiesinger@google.com>
+ * configure: Regenerate.
+ * configure.ac: Remove code that sets python_has_threads.
+
+2019-10-24 Christian Biesinger <cbiesinger@google.com>
+
* config.in: Regenerate.
* configure: Regenerate.
* configure.ac: Remove the code that uses sed to get the python
diff --git a/gdb/configure b/gdb/configure
index dcd6141..4e2247d 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -10664,34 +10664,6 @@
fi
;;
esac
-
- # Note that "python -m threading" cannot be used to check for
- # threading support due to a bug in Python 2.7.3
- # (http://bugs.python.org/issue15567).
- { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether python supports threads" >&5
-$as_echo_n "checking whether python supports threads... " >&6; }
- saved_CPPFLAGS="${CPPFLAGS}"
- CPPFLAGS="${PYTHON_CPPFLAGS}"
- # Note that the test is reversed so that python_has_threads=yes on
- # unexpected failures.
- cat confdefs.h - <<_ACEOF >conftest.$ac_ext
-/* end confdefs.h. */
-
-#include <Python.h>
-#ifdef WITH_THREAD
-# error
-#endif
-
-_ACEOF
-if ac_fn_c_try_cpp "$LINENO"; then :
- python_has_threads=no
-else
- python_has_threads=yes
-fi
-rm -f conftest.err conftest.i conftest.$ac_ext
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: ${python_has_threads}" >&5
-$as_echo "${python_has_threads}" >&6; }
- CPPFLAGS="${saved_CPPFLAGS}"
else
# Even if Python support is not compiled in, we need to have this file
# included so that the "python" command, et.al., still exists.
diff --git a/gdb/configure.ac b/gdb/configure.ac
index f11dccd..cb331be 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -948,23 +948,6 @@
fi
;;
esac
-
- # Note that "python -m threading" cannot be used to check for
- # threading support due to a bug in Python 2.7.3
- # (http://bugs.python.org/issue15567).
- AC_MSG_CHECKING(whether python supports threads)
- saved_CPPFLAGS="${CPPFLAGS}"
- CPPFLAGS="${PYTHON_CPPFLAGS}"
- # Note that the test is reversed so that python_has_threads=yes on
- # unexpected failures.
- AC_PREPROC_IFELSE([AC_LANG_SOURCE([[
-#include <Python.h>
-#ifdef WITH_THREAD
-# error
-#endif
- ]])], [python_has_threads=no], [python_has_threads=yes])
- AC_MSG_RESULT(${python_has_threads})
- CPPFLAGS="${saved_CPPFLAGS}"
else
# Even if Python support is not compiled in, we need to have this file
# included so that the "python" command, et.al., still exists.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I75f1b873562bc2abc6f2db17699a3e82fcfd2de3
Gerrit-Change-Number: 301
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: newpatchset