Re: [PATCH 0/2] Improved variable object invalidation in GDB

[Luis Machado <luis dot machado at linaro dot org>]

Hi,

Before reviewing the patch itself, could you please expand, with more 
detail, what the use case is for this particular fix?

It seems to be the same patch Taimoor sent a while ago, so in order to 
improve its chances of getting accepted, it would be nice to have a bit 
more background.

In particular, adding varobj bits to objfiles.[c] is a bit strange. 
Varobj access seems to be restricted to core varobj implementations and 
language support only.

It may be a sign that something more fundamental is missing, like an 
interface of some kind, an observer or a notification.

Better understanding the use case will allow us to determine where/how 
exactly this should be fixed.

Luis

On 10/17/19 7:03 AM, Raza, Saqlain wrote:
> Hi,
> This patch series improves variable object invalidation in GDB.
>
> This is a followup to the patch series submission made in https://sourceware.org/ml/gdb-patches/2015-04/msg00598.html . This problem still holds in the latest GDB master.
>
> Raza, Saqlain (2):
>    Fix varobj updation after symbol removal
>    Testsuite for varobj updation after symbol removal
>
>   gdb/ChangeLog                              |  13 ++
>   gdb/objfiles.c                             |  19 ++
>   gdb/testsuite/ChangeLog                    |  11 +
>   gdb/testsuite/gdb.mi/mi-var-invalidate.exp |  68 ++++++
>   gdb/testsuite/gdb.mi/sym-file-lib.c        |  28 +++
>   gdb/testsuite/gdb.mi/sym-file-loader.c     | 355 +++++++++++++++++++++++++++++
>   gdb/testsuite/gdb.mi/sym-file-loader.h     | 101 ++++++++
>   gdb/testsuite/gdb.mi/sym-file-main.c       |  86 +++++++
>   gdb/varobj.c                               |  35 +++
>   gdb/varobj.h                               |   4 +
>   10 files changed, 720 insertions(+)
>   create mode 100644 gdb/testsuite/gdb.mi/sym-file-lib.c
>   create mode 100644 gdb/testsuite/gdb.mi/sym-file-loader.c
>   create mode 100644 gdb/testsuite/gdb.mi/sym-file-loader.h
>   create mode 100644 gdb/testsuite/gdb.mi/sym-file-main.c