This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review v2] infcall: remove unused parameter in 'value_arg_coerce'
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Tankut Baris Aktemur <tankut dot baris dot aktemur at intel dot com>, gdb-patches at sourceware dot org
- Date: Tue, 22 Oct 2019 08:46:55 -0400
- Subject: [review v2] infcall: remove unused parameter in 'value_arg_coerce'
- Auto-submitted: auto-generated
- References: <gerrit.1571406803000.If324a1dda3fa5d4c145790b92bd3f656c00296f4@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, tankut dot baris dot aktemur at intel dot com, gdb-patches at sourceware dot org
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/140
......................................................................
Patch Set 2:
> Thank you. This is a patch in a series, but it does not depend on other patches; so it can be applied first. Is it OK to merge it without other patches receiving an OK? Is there a concrete about this?
I think it depends on the patch.
My view of the rule is that if a patch is desirable for its own sake, then it
can go in immediately. On the other hand, if a patch is only useful in
conjunction with some other patch, then it should wait.
> Also, I don't have write access to the repository. Would you be able to apply this change, or may I be granted write access?
Please contact me off-list and we can get you set up with write-after-commit
access (assuming your copyright paperwork is in order). The rule in gdb is that
you must have one approved patch to get access.