This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[review] Test making delayed_method_info vectors local variables
- From: "Tom Tromey (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Tue, 22 Oct 2019 09:39:50 -0400
- Subject: [review] Test making delayed_method_info vectors local variables
- Auto-submitted: auto-generated
- References: <gerrit.1571288934000.I0583a6a7cdc5945fd732bd0b75ab542843c2f03f@gnutoolchain-gerrit.osci.io>
- Reply-to: tromey at sourceware dot org, simon dot marchi at polymtl dot ca, gdb-patches at sourceware dot org
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/128
......................................................................
Patch Set 1:
FWIW I think the idea is that `dwarf2_cu` should exist just to hold
temporary data that's used when reading a CU -- and then be discarded.
So, in effect, it should already be a form of local variable.
Whether or not it works this way in practice is hard to tell, because
dwarf2read has a spaghetti-like nature. It would be great to clean
all this up (say, replace things like `init_cutu_and_read_dies` with
a constructor), but of course that's a big job.