Re: [PATCH] gdb: remove unused includes from dwarf2read.c

[Luis Machado <luis dot machado at linaro dot org>]

On 10/14/19 11:38 AM, Eli Zaretskii wrote:
> > Date: Mon, 14 Oct 2019 10:21:50 -0400
> > From: Simon Marchi <simon.marchi@polymtl.ca>
> >
> > I pushed it after Tom de Vries reviewed it on Gerrit:
> >
> > https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/24
>
> Does this mean that now we need to look for patches in two places?
> Can Gerrit be set up to forward the review comments to the list?
>
> Also, if some of us decides to do the review on Gerrit, does it mean
> all the others need to do that as well?

The transition to some better (restrictions may apply) patch reviewing 
system is a good thing, but i agree we should think further about it. 
Personally i think we should discuss and then decide on a date by which 
we will fully transition to it.

Otherwise there is the potential for confusion since people will have to 
look into two different places for patches. People may review stuff on 
gerrit and the mailing list at the same time. This split isn't great and 
is prone to cause collision of suggestions due to reviewers not being 
aware of each other. etc.

Ideally we'd put gerrit up when it is fully configured and functional, 
being able to merge patches automatically. Then only maintainers will be 
able to +2 (approve) patches and verify contributors meet the legal 
requisites as is already the case with mailing lists?