This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: remove unused includes from dwarf2read.c
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: gdb-patches at sourceware dot org
- Date: Mon, 14 Oct 2019 10:21:50 -0400
- Subject: Re: [PATCH] gdb: remove unused includes from dwarf2read.c
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9EELpnq010802
- References: <20191013045218.3261363-1-simon.marchi@polymtl.ca>
On 2019-10-13 00:52, Simon Marchi wrote:
include-what-you-use says:
../../../src/binutils-gdb/gdb/dwarf2read.c should remove these lines:
- #include <ctype.h> // lines 67-67
- #include <sys/stat.h> // lines 59-59
- #include <sys/types.h> // lines 83-83
- #include <cmath> // lines 88-88
- #include <forward_list> // lines 90-90
- #include <set> // lines 89-89
- #include <unordered_set> // lines 85-85
- #include "completer.h" // lines 60-60
- #include "expression.h" // lines 44-44
- #include "gdbsupport/byte-vector.h" // lines 78-78
- #include "gdbsupport/filestuff.h" // lines 71-71
- #include "gdbsupport/gdb_unlinker.h" // lines 74-74
After a quick glance, that makes sense, so this patch removes them.
Change-Id: I13cfcb2f1d747144fddba7f66b329630b79dae90
I pushed it after Tom de Vries reviewed it on Gerrit:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/24
Simon