This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3][GDB][ARM]: gdb cannot step across CMSE secure entry function code.
- From: Simon Marchi <simark at simark dot ca>
- To: Srinath Parvathaneni <Srinath dot Parvathaneni at arm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: nd <nd at arm dot com>, "tom at tromey dot com" <tom at tromey dot com>, Alan Hayward <Alan dot Hayward at arm dot com>
- Date: Mon, 22 Jul 2019 11:58:00 -0400
- Subject: Re: [PATCH v3][GDB][ARM]: gdb cannot step across CMSE secure entry function code.
- References: <DBBPR08MB47759CB06F588942CAC222FE9BC40@DBBPR08MB4775.eurprd08.prod.outlook.com>
Hi Srinath,
Just a formatting nit:
> +static CORE_ADDR
> +arm_skip_cmse_entry (CORE_ADDR pc, const char *name, struct objfile *objfile)
> +{
> + int target_len = strlen (name) + strlen ("__acle_se_") + 1;
> + char *target_name = (char *) alloca (target_len);
> + xsnprintf (target_name, target_len, "%s%s", "__acle_se_", name);
> +
> + struct bound_minimal_symbol minsym
> + = lookup_minimal_symbol (target_name, NULL, objfile);
Missing one space here, before the equal. No need to send a new version for this
if everything else is fine, just make sure to fix it before pushing.
Thanks,
Simon