This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3][GDB][ARM]: gdb cannot step across CMSE secure entry function code.
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Simon Marchi <simark at simark dot ca>, Srinath Parvathaneni <Srinath dot Parvathaneni at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>, "tom at tromey dot com" <tom at tromey dot com>
- Date: Tue, 23 Jul 2019 11:16:11 +0000
- Subject: Re: [PATCH v3][GDB][ARM]: gdb cannot step across CMSE secure entry function code.
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WGKRavknrXPfqCh3AKg4ZSl1ciwU/nj5DtwjJ9Iu2/E=; b=fN7n/TQFn7vsDiJn1Qgvgvm4ULIX6iP5dsi07r3xa+j3a/hoPkfT1XEQ65gYQPslnFfmeZGUUpGIRXRethpR+ddRMGR4d+n+zqigEDDK2mnJQ4sdPxsxAzXWk9kvRanHDn9sgwbCZbPUAqX34LvIGi/VxMYo2xlIQs36/+7vWxqjz34fx8VgPSTPwl4OyARRMDQzOz8kr0odXdVeJkL5/vBJpbsVJobP/4MY/7XVXaHpfm3ck5Eu+sQ1p3IcLibZ0wH5h1uSk8iS1P7cmvIR6cK+OFcBiOnQWK5O8/9HwaMdjlrVdQFpmkjdzqw25ne3i1RwQ+EZyYkt6Ysquh0Q/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MO7qDkZrZ+HilC0YtivveijgMmnRYnGvLr8ai0v4KGxRCz390irK1FK2HIoUsSVgWcQoDUoGDhq4EVwngWlshz5B1lpppwr6Ms2idnx0Fu9zGAssla5FHYCr6xjyZi7KoFmG7AUPY/C9dUpqiOuAcs5YuLjZ0TDSQrZeOE6I77+I42/X8nYqdI4YSWCIlgLtLbVc/ENKII0OhEe862PGgaeGZc1cvSjqEWiCf5w8Xscweasjul62BGUT9yoPabpJUijpyV0tBKQb+4jmpBka3KEsVwOaw+uoPvFYLGatbsCfW69OvXGddwwaOh+s/8GyCyyUR6Ut4qdNUMh7c2LA/w==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan dot Hayward at arm dot com;
- References: <DBBPR08MB47759CB06F588942CAC222FE9BC40@DBBPR08MB4775.eurprd08.prod.outlook.com> <78c3df39-f362-fa92-1c59-2b36d11a6bec@simark.ca>
> On 22 Jul 2019, at 16:58, Simon Marchi <simark@simark.ca> wrote:
>
> Hi Srinath,
>
> Just a formatting nit:
>
>> +static CORE_ADDR
>> +arm_skip_cmse_entry (CORE_ADDR pc, const char *name, struct objfile *objfile)
>> +{
>> + int target_len = strlen (name) + strlen ("__acle_se_") + 1;
>> + char *target_name = (char *) alloca (target_len);
>> + xsnprintf (target_name, target_len, "%s%s", "__acle_se_", name);
>> +
>> + struct bound_minimal_symbol minsym
>> + = lookup_minimal_symbol (target_name, NULL, objfile);
>
> Missing one space here, before the equal. No need to send a new version for this
> if everything else is fine, just make sure to fix it before pushing.
>
I’ve pushed this on behalf of Srinath.
Thanks!
Alan.