This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA 2/3] Add missing ATTRIBUTE_NORETURNs
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Tue, 27 Sep 2016 12:16:31 -0600
- Subject: [RFA 2/3] Add missing ATTRIBUTE_NORETURNs
- Authentication-results: sourceware.org; auth=none
- References: <1475000192-8789-1-git-send-email-tom@tromey.com>
This patch adds a couple of missing ATTRIBUTE_NORETURNs. This lets
-Wimplicit-fallthrough recognize that a given case does not fall
through.
2016-09-27 Tom Tromey <tom@tromey.com>
* dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
* completer.h (throw_max_completions_reached_error): Add
ATTRIBUTE_NORETURN.
---
gdb/ChangeLog | 6 ++++++
gdb/completer.h | 3 ++-
gdb/dwarf2loc.c | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fdd43ab..83b051f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2016-09-27 Tom Tromey <tom@tromey.com>
+ * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
+ * completer.h (throw_max_completions_reached_error): Add
+ ATTRIBUTE_NORETURN.
+
+2016-09-27 Tom Tromey <tom@tromey.com>
+
* xcoffread.c (scan_xcoff_symtab): Move comment later.
* symfile.c (section_is_mapped): Fix fall-through comment.
* stabsread.c (define_symbol, read_member_functions): Fix
diff --git a/gdb/completer.h b/gdb/completer.h
index 24bfee9..ff01f86 100644
--- a/gdb/completer.h
+++ b/gdb/completer.h
@@ -179,6 +179,7 @@ extern enum maybe_add_completion_enum
/* Wrapper to throw MAX_COMPLETIONS_REACHED_ERROR. */
-extern void throw_max_completions_reached_error (void);
+extern void throw_max_completions_reached_error (void)
+ ATTRIBUTE_NORETURN;
#endif /* defined (COMPLETER_H) */
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index f9f3216..a29c9ed 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -2917,7 +2917,7 @@ dwarf2_loc_desc_get_symbol_read_needs (const gdb_byte *data, size_t size,
/* A helper function that throws an unimplemented error mentioning a
given DWARF operator. */
-static void
+static void ATTRIBUTE_NORETURN
unimplemented (unsigned int op)
{
const char *name = get_DW_OP_name (op);
--
2.7.4