Re: [patch] pr11371 conditional watchpoints with a function in the condition.

[Chris Moller <cmoller at redhat dot com>]

Sorry about that...

cm

On 06/04/10 16:14, Jan Kratochvil wrote:
> On Fri, 04 Jun 2010 19:24:05 +0200, Chris Moller wrote:
>    
> > +  if (b->type != bp_watchpoint&&  b->type != bp_hardware_watchpoint&&
> > +      b->enable_state != bp_call_disabled)
> >      
>
> `&&' should be on the second line.
> 	http://www.gnu.org/prep/standards/standards.html#Formatting
> 	When you split an expression into multiple lines, split it before an
> 	operator, not after one.
>
>
>    
> > +Running ../../../src/gdb/testsuite/gdb.base/pr11371.exp ...
> > +PASS: gdb.base/pr11371.exp: watch aa if cond(aa)
> > +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
> > +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
> > +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
> >      
>
> Apparently you have written a new testcase but forgot to attach it.
> I have not tried to do real a review without the testcase.
>
>
> Thanks,
> Jan
>

Attachment: pr11371.exp
Description: Text document

/* This test is part of GDB, the GNU debugger.

   Copyright 2010 Free Software Foundation, Inc.

   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation; either version 3 of the License, or
   (at your option) any later version.

   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.

   You should have received a copy of the GNU General Public License
   along with this program.  If not, see <http://www.gnu.org/licenses/>.
   */

int aa = 4;

int
cond(int a)
{
  return a == 6;
}

main()
{
  aa = 5;
  aa = 6;
  aa = 7;

  return 0;
}