This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] pr11371 conditional watchpoints with a function in the condition.
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Chris Moller <cmoller at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 4 Jun 2010 22:14:10 +0200
- Subject: Re: [patch] pr11371 conditional watchpoints with a function in the condition.
- References: <4C0936B5.9080002@redhat.com>
On Fri, 04 Jun 2010 19:24:05 +0200, Chris Moller wrote:
> + if (b->type != bp_watchpoint && b->type != bp_hardware_watchpoint &&
> + b->enable_state != bp_call_disabled)
`&&' should be on the second line.
http://www.gnu.org/prep/standards/standards.html#Formatting
When you split an expression into multiple lines, split it before an
operator, not after one.
> +Running ../../../src/gdb/testsuite/gdb.base/pr11371.exp ...
> +PASS: gdb.base/pr11371.exp: watch aa if cond(aa)
> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint
Apparently you have written a new testcase but forgot to attach it.
I have not tried to do real a review without the testcase.
Thanks,
Jan