This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step

>>>>> "KB" == Kevin Buettner <kevinb@redhat.com> writes:

 KB> Would you mind doing some tracing to figure out why wrapping it
 KB> with a test for AIX wasn't necessary?  The fact that you didn't
 KB> need a test suggests that there's a bug somewhere else...

gdb/config/powerpc/tm-ppc-eabi.h defines the predicate
SOFTWARE_SINGLE_STEP_P() as 0 but does not define
SOFTWARE_SINGLE_STEP() at all. If I remove this def then all works as
expected.

So what should the AIX test be? possible canidates are:
  ? if (info.osabi != GDB_OSABI_LINUX)
    * Not sure if this is good enough for the PPC-EABI or anyone else
  ? if (from_xcoff_exec)

or clear it to NULL in ppclinux and eabi.

thoughts?
-JX
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]