This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step
On Sep 8, 5:22pm, Jimi Xenidis wrote:
> >>>>> "DJ" == Daniel Jacobowitz <drow@mvista.com> writes:
> DJ> Are you sure you posted the patch you tested?
>
> yes and it was tested on aix.
>
> DJ> You added a call to set_gdbarch_software_single_step to
> DJ> rs6000_gdbarch_init. It wasn't conditional on anything relating to
> DJ> AIX. By all rights that _should_ set gdbarch_software_singlestep_p for
> DJ> GNU/Linux.
>
> I agree with you and am equally puzzled, but it does not, I expected
> to wrap it in:
> if (info->osabi != GDB_OSABI_LINUX)
> but it was not necessary.
> Actually wanted == GDB_OSABI_AIX but there was no such animal.
>
> thoughts?
Would you mind doing some tracing to figure out why wrapping it
with a test for AIX wasn't necessary? The fact that you didn't
need a test suggests that there's a bug somewhere else...
Kevin