This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ld: Fix printed sizes in map file
- From: Alan Modra <amodra at gmail dot com>
- To: Christian Eggers <ceggers at gmx dot de>
- Cc: binutils at sourceware dot org
- Date: Tue, 5 Nov 2019 20:01:58 +1030
- Subject: Re: [PATCH] ld: Fix printed sizes in map file
- References: <20191104081014.14963-1-ceggers@gmx.de>
On Mon, Nov 04, 2019 at 09:10:14AM +0100, Christian Eggers wrote:
> + * ldlang.c (print_input_section): Shift printed size by opb_shift.
OK, but
> - minfo ("0x%V %W %pB\n", addr, size, i->owner);
> + minfo ("0x%V %W %pB\n", addr, TO_ADDR(size), i->owner);
to comply with the GNU coding standards, there should be a space
between the macro and the opening parenthesis.
> if (size != i->rawsize && i->rawsize != 0)
Please fix the rawsize display too.
--
Alan Modra
Australia Development Lab, IBM