This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ld: Fix printed sizes in map file
> to comply with the GNU coding standards, there should be a space
> between the macro and the opening parenthesis.
changed.
>> if (size != i->rawsize && i->rawsize != 0)
> Please fix the rawsize display too.
probably done, but I don't know how to test this on my platform
regards
Christian
From dec380266d7a01a26aa76bfbfe792cd4d155c2db Mon Sep 17 00:00:00 2001
From: Christian Eggers <ceggers@gmx.de>
Date: Mon, 4 Nov 2019 08:34:54 +0100
Subject: [PATCH] ld: Fix printed sizes in map file
For targets with octets_per_byte>1, testsuite/ld-scripts/rgn-over*
produce wrong sizes in the generated map files:
.text 0x0000000000001000 0x6
^^^ # correct
*(.txt)
.txt 0x0000000000001000 0xc tmpdir/rgn-over.o
^^^ # should also be 0x6
The size in the first line is generated in ldlang.c:4436:
minfo ("0x%V %W", section->vma, TO_ADDR (section->size));
The size in the third line is generated in ldlang.c:4656:
minfo ("0x%V %W %pB\n", addr, size, i->owner);
* ldlang.c (print_input_section): Shift printed size by opb_shift.
Signed-off-by: Christian Eggers <ceggers@gmx.de>
---
ld/ldlang.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ld/ldlang.c b/ld/ldlang.c
index df7f659486..eedcb7f405 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -4653,7 +4653,7 @@ print_input_section (asection *i, bfd_boolean is_discarded)
size = 0;
}
- minfo ("0x%V %W %pB\n", addr, size, i->owner);
+ minfo ("0x%V %W %pB\n", addr, TO_ADDR (size), i->owner);
if (size != i->rawsize && i->rawsize != 0)
{
@@ -4669,7 +4669,7 @@ print_input_section (asection *i, bfd_boolean is_discarded)
--len;
}
- minfo (_("%W (size before relaxing)\n"), i->rawsize);
+ minfo (_("%W (size before relaxing)\n"), TO_ADDR (i->rawsize));
}
if (i->output_section != NULL
--
2.16.4