This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode

From: Jiong Wang <jiong dot wang at foss dot arm dot com>
To: Yury Norov <ynorov at caviumnetworks dot com>
Cc: binutils at sourceware dot org, Andreas Schwab <schwab at suse dot de>
Date: Thu, 19 Jan 2017 16:16:06 +0000
Subject: Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
Authentication-results: sourceware.org; auth=none
References: <1484825847-30407-1-git-send-email-ynorov@caviumnetworks.com> <n99ziinniog.fsf@foss.arm.com> <20170119160814.GA501@yury-N73SV>



On 19/01/17 16:08, Yury Norov wrote:

On Thu, Jan 19, 2017 at 03:47:20PM +0000, Jiong Wang wrote:

And the following coding style nits, otherwise looks good to me.

Yury Norov writes:

+#else /*ARCH_SIZE == 32 */

/* ARCH_SIZE == 32 */

+	  bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 4);

Over 80 columns.

+	  bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 0);

Likewise.

--
Regards,
Jiong

Does it mean I can push it after addressing your and Andreas'
comments, or I should wait for other approves?

You need to wait either AArch64 maintainer's approval (Richard Earnshawor Marcus Shawcroft) or head maintainer's approval (Nick)


See section "Maintainers" in binutils/MAINTAINERS,  it describes the policy.


Regards,
Jiong

References:
- [PATCH] aarch64: ld: fix relaxations for ilp32 mode
  - From: Yury Norov
- Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
  - From: Jiong Wang
- Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
  - From: Yury Norov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]