This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: <binutils at sourceware dot org>, Andreas Schwab <schwab at suse dot de>
- Date: Thu, 19 Jan 2017 21:38:14 +0530
- Subject: Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1484825847-30407-1-git-send-email-ynorov@caviumnetworks.com> <n99ziinniog.fsf@foss.arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Thu, Jan 19, 2017 at 03:47:20PM +0000, Jiong Wang wrote:
>
> And the following coding style nits, otherwise looks good to me.
>
> Yury Norov writes:
>
> > +#else /*ARCH_SIZE == 32 */
>
> /* ARCH_SIZE == 32 */
>
> > + bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 4);
>
> Over 80 columns.
>
> > + bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 0);
>
> Likewise.
>
> --
> Regards,
> Jiong
Does it mean I can push it after addressing your and Andreas'
comments, or I should wait for other approves?
Yury