This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
- From: Jiong Wang <jiong dot wang at foss dot arm dot com>
- To: Yury Norov <ynorov at caviumnetworks dot com>
- Cc: binutils at sourceware dot org, Andreas Schwab <schwab at suse dot de>
- Date: Thu, 19 Jan 2017 15:47:20 +0000
- Subject: Re: [PATCH] aarch64: ld: fix relaxations for ilp32 mode
- Authentication-results: sourceware.org; auth=none
- References: <1484825847-30407-1-git-send-email-ynorov@caviumnetworks.com>
And the following coding style nits, otherwise looks good to me.
Yury Norov writes:
> +#else /*ARCH_SIZE == 32 */
/* ARCH_SIZE == 32 */
> + bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 4);
Over 80 columns.
> + bfd_putl32 (add_R0_R0 | (TCB_SIZE << 10), contents + rel->r_offset + 0);
Likewise.
--
Regards,
Jiong