This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: Re: [PATCHv2 0/2] Add initial arc nps400 support

* Nick Clifton <> [2016-03-15 11:14:44 +0000]:

> Hi Andrew,
> > PING!  I've had some great feedback from Claudiu, but I'm still hoping
> > for a global maintainer to cast an eye over this too please.
> Oops - sorry - dropped the ball on this one.

No problem.  Thanks for the review.

> The patches (1 and 2) both look fine to me, apart from one very small issue:
> The new assembler test control files (gas/testsuite/gas/arc/nps400-0.d and
> gas/testsuite/gas/arc/nps400-1.d) both restrict the test to:
>   #target: arc*-mellanox-*
> What is "mellanox" and why is it included in the target string ?  The name
> is not present in the gas/configure.tgt or bfd/config.bfd files, so I am
> assuming that it is a manufacturer name and not an OS name.  If so then its
> presence in these tests will stop them from being run with toolchains 
> configured with, for example, --target=arc-elf.  (This matters to me, since
> that is one of the configurations I use in my daily regression
> testing).

Patch #2 adds this name to the opcodes/configure script.  I
deliberately tried to minimise the number of configure scripts I

The mellanox nps400 core is an ARC700 with a set of vendor extension
instructions added into the gap that is left in the ARC700
architecture specifically for such instructions.

So, at the moment, when we configure with arc*-mellanox-* in the
opcodes directory we build the standard arc opcodes library, but
include an additional set of instructions that sit in the gap.
Everything else (right now) bfd/gas/etc is unchanged.

In the future this might not be the case, for bfd/ld I do have some
small patches to submit, but they can wait for another day.  I'm
hopeful that gas might not require any mellanox specific changes

With this new knowledge, are the patches still OK?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]