This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, AARCH64] gc-section support


On 22/02/13 17:25, Venkataramanan Kumar wrote:
Hi Maintainers,


Hi,

Thanks for the patch!

Attached is a small patch that enables gc-section support for AARCH64.

In the sweep hook I have handled TLS and GOT related relocs that were
already supported in that file.


@@ -4866,8 +4866,8 @@ elf64_aarch64_print_private_bfd_data (bfd *abfd, void *ptr)
   return TRUE;
 }

-/* Update the got entry reference counts for the section being removed. */

+/* Update the got entry reference counts for the section being removed.  */
 static bfd_boolean
 elf64_aarch64_gc_sweep_hook (bfd *abfd ATTRIBUTE_UNUSED,
 			     struct bfd_link_info *info ATTRIBUTE_UNUSED,

Please drop this change.


static bfd_boolean
elf64_aarch64_gc_sweep_hook (bfd *abfd ATTRIBUTE_UNUSED,
			     struct bfd_link_info *info ATTRIBUTE_UNUSED,
			     asection *sec ATTRIBUTE_UNUSED,
			     const Elf_Internal_Rela *
			     relocs ATTRIBUTE_UNUSED)

Please review and drop ATTRIBUTE_UNUSED to reflect the new implementation of this function.



+  if (htab == NULL)
+	return FALSE;

The white space in this patch needs further cleaning up. TAB width should be 8 (the above suggests the patch was written with tab width set at 4?). Further down the patch there are also instances of trailing
white space, which should be removed.



Cheers /Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]