This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] m68k: fix weak undefined PIE tests
- From: Alan Modra <amodra at gmail dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: binutils at sourceware dot org
- Date: Thu, 26 Apr 2012 23:03:36 +0930
- Subject: Re: [PATCH] m68k: fix weak undefined PIE tests
- References: <m27gx6xr2f.fsf@igel.home>
On Mon, Apr 23, 2012 at 08:04:40PM +0200, Andreas Schwab wrote:
> * elf32-m68k.c (elf_m68k_check_relocs): Mark non-GOT references
> also when generating PIE.
> (elf_m68k_discard_copies): Mark undefined weak symbols referenced
> by relocations as dynamic.
Looks reasonable, except
> - if (!info->shared)
> + if (!info->shared || info->executable)
this should just be "if (info->executable)". !shared is redundant.
--
Alan Modra
Australia Development Lab, IBM