This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS/GAS/testsuite: Fine-grained MIPS FP ISA matching

"Maciej W. Rozycki" <> writes:
>  But you're right in principle and I have now skimmed over the tests we 
> run and adjusted these I remembered to be qualifying too.  Below is the 
> result.  There may be more candidates, especially with some cases we don't 
> currently run across multiple subarchitectures.  This is good enough for 
> now though, I think.  I've checked it does the right thing.

Ah, OK, with this patch it is indeed more convincing.

>  Thanks for the review.  I think it will make sense if I merge the two 
> changes into one and commit them together.  Do you agree?


> 2011-08-10  Maciej W. Rozycki  <>
>         gas/testsuite/
> 	* gas/mips/mips.exp: Define new "fpisa3", "fpisa4" and "fpisa5"
> 	architecture properties adding them to "mips3", "mips4", "mips5"
> 	and "mips32r2" architectures.  Use the new properties for the
> 	"24k-triple-stores-1", "24k-triple-stores-3", "mips4-fp",
> 	"mips5" and "alnv_ps-swap" tests.

OK, but...

> -    run_dump_test_arches "mips5"	[mips_arch_list_matching mips5]
> +    run_dump_test_arches "mips5"	[mips_arch_list_matching fpisa5]

...please also rename mips5 to mips5-fp (as part of the same commit
or separately, whichever you prefer).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]