[PATCHv2 1/2] Fix semantic error: empty struct

[James Bottomley]

On Tue, 2008-07-08 at 14:16 -0400, Frank Ch. Eigler wrote:
> Hi -
> 
> Thanks for the revised patch, looks good.  I have two questions.  Can
> you explain why the "global_alias_cache" seems like it should be a
> static member, rather than ordinary member of dwflpp?  (dwflpp
> instances are relatively long-lived, and already have a formal cache
> release mechanism.)

you need a global cache for resolution ... it's not tied to any local
class instance.  For class dwflpp it probably doesn't matter, since that
class is effectively static (by its survival for a session) but
logically because the DW_AT_declaration resolution is global, so should
the cache that does it.

> Also, doesn't it seem like the stap_compile{} dejagnu proc seems
> unnecessarily complicated (like some other such functions in the
> testsuite)?  You could just have your .exp file do
> 
>      spawn stap -p4 $srcdir/$subdir/script.stp
>      expect { ... }
>      close; wait

perhaps it would be if I invented it.  In fact, I just recycled it from
markers.exp, the declaration.exp just needed access.

James