[PATCHv2 1/2] Fix semantic error: empty struct

Frank Ch. Eigler fche@redhat.com
Tue Jul 8 18:17:00 GMT 2008


Hi -

Thanks for the revised patch, looks good.  I have two questions.  Can
you explain why the "global_alias_cache" seems like it should be a
static member, rather than ordinary member of dwflpp?  (dwflpp
instances are relatively long-lived, and already have a formal cache
release mechanism.)

Also, doesn't it seem like the stap_compile{} dejagnu proc seems
unnecessarily complicated (like some other such functions in the
testsuite)?  You could just have your .exp file do

     spawn stap -p4 $srcdir/$subdir/script.stp
     expect { ... }
     close; wait

- FChE



More information about the Systemtap mailing list