[RFA]: hw-glue-bus-mux selection behavior
Frank Ch. Eigler
fche@redhat.com
Tue Mar 27 16:05:00 GMT 2001
Hi -
On Tue, Mar 27, 2001 at 06:39:47PM -0500, Dave Brolley wrote:
: [...]
: Notes:
: 1) I actually implemented the selector to choose "downstream1" when the
: pin value is even and "downstream2" otherwise. [...]
To me, this seems like an unnecessary feature; I'd let the client pick
exactly 0 or 1.
: 2) I left the mux_passthrough_bus::switch_bus function in since it still
: seems like useful functionality for other subclasses.
Hmm. For what it's worth, I wouldn't have put the mux_passthrough
thingie into sid/include/ at all. It looks like a specialized enough
piece of code that I'd have kept it inside the source directory of
the appropriate glue component.
: OK to commit?
Sure; up to you if you want to take my mild objections into consideration.
- FChE
--
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE6wSqmVZbdDOm/ZT0RAqKsAJ9oKw/zlbI1726JFv0EM/dGq3lNTwCdGixL
gLlHP6fV4QJSRCsihsGu/5w=
=TNAM
-----END PGP SIGNATURE-----
More information about the Sid
mailing list