riscv fenv.h header file guard typo

Kito Cheng kito.cheng@gmail.com
Fri Aug 2 03:39:00 GMT 2019


Hi Joel:

Thanks, I've send a patch for that :)

https://www.sourceware.org/ml/newlib/2019/msg00407.html

On Thu, Aug 1, 2019 at 7:13 AM Howland, Craig D. - US via newlib
<newlib@sourceware.org> wrote:
>
>
> ________________________________________
> From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Joel Sherrill <joel@rtems.org>
> Sent: Wednesday, July 31, 2019 6:47 PM
> To: Newlib
> Subject: riscv fenv.h header file guard typo
>
> Hi
>
> While working on the proposed fenv.h infrastructure support, I noticed that
> the riscv fenv.h and sys/fenv.h appear to have very similar header guards
> (only a trailing _ differentiates them).
>
> /libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
> ./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_
>
> Would it be better for sys/fenv.h to have _SYS_FENV_H?
>
> --joel
>
> Yes, better.



More information about the Newlib mailing list