riscv fenv.h header file guard typo

Howland, Craig D. - US via newlib newlib@sourceware.org
Wed Jul 31 23:13:00 GMT 2019

From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Joel Sherrill <joel@rtems.org>
Sent: Wednesday, July 31, 2019 6:47 PM
To: Newlib
Subject: riscv fenv.h header file guard typo


While working on the proposed fenv.h infrastructure support, I noticed that
the riscv fenv.h and sys/fenv.h appear to have very similar header guards
(only a trailing _ differentiates them).

/libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_

Would it be better for sys/fenv.h to have _SYS_FENV_H?


Yes, better.

More information about the Newlib mailing list