[PATCH] _lseek missing return type

Corinna Vinschen vinschen@redhat.com
Fri Feb 9 17:30:00 GMT 2018


On Feb  9 09:40, Jaap de Wolff wrote:
> In syscalls _lseek was missing a return type
> 
> Jaap de Wolff
> 
> diff --git a/libgloss/arm/syscalls.c b/libgloss/arm/syscalls.c
> index 8163c7983..5548dcfb3 100644
> --- a/libgloss/arm/syscalls.c
> +++ b/libgloss/arm/syscalls.c
> @@ -493,6 +493,7 @@ _swilseek (int fd,
>      return -1;
>  }
>  
> +int
>  _lseek (int fd,
>  	int ptr,
>  	int dir)
> 

I'm somewhat aghast at this.  lseek is supposed to return off_t and
the ptr parameter should be off_t as well.  Shouldn't this be fixed
the right way?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20180209/fd21e104/attachment.sig>


More information about the Newlib mailing list