[PATCH,MIPS 1/3] Re-work setjmp/longjmp to match o32 FPXX and FP64 ABI

Corinna Vinschen vinschen@redhat.com
Fri Nov 28 08:48:00 GMT 2014


On Nov 27 23:44, Matthew Fortune wrote:
> > On Nov 26 15:33, Steve Ellcey wrote:
> > > On Wed, 2014-11-26 at 14:47 -0800, Matthew Fortune wrote:
> > >
> > > > This could then be used as GPR_FPOFFSET(11) instead of
> > > > GPR_OFFSET(22) though it is perhaps just as confusing.
> > > >
> > > > Any suggestions and/or does it make more sense now?
> > > >
> > > > Thanks for the review,
> > > > Matthew
> > >
> > > Thanks for the explanation, that helped.  I don't think the new macro
> > > would help much but maybe some of the explanation from your email
> > > could be put into the code comments.
> > >
> > > Steve Ellcey
> > 
> > Thanks guys!  I agree with Steve.  The patch will be better
> > understandable in future with the explanation as comment.
> 
> I've added a comment to cover what I said on this thread, it is phrased
> as cleanly as I could think of. I am more than happy to work on it
> further if anyone has any suggestions to improve it.

Patch applied.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20141128/9214c903/attachment.sig>


More information about the Newlib mailing list