[PATCH,MIPS 1/3] Re-work setjmp/longjmp to match o32 FPXX and FP64 ABI
Matthew Fortune
Matthew.Fortune@imgtec.com
Thu Nov 27 23:44:00 GMT 2014
> On Nov 26 15:33, Steve Ellcey wrote:
> > On Wed, 2014-11-26 at 14:47 -0800, Matthew Fortune wrote:
> >
> > > This could then be used as GPR_FPOFFSET(11) instead of
> > > GPR_OFFSET(22) though it is perhaps just as confusing.
> > >
> > > Any suggestions and/or does it make more sense now?
> > >
> > > Thanks for the review,
> > > Matthew
> >
> > Thanks for the explanation, that helped. I don't think the new macro
> > would help much but maybe some of the explanation from your email
> > could be put into the code comments.
> >
> > Steve Ellcey
>
> Thanks guys! I agree with Steve. The patch will be better
> understandable in future with the explanation as comment.
I've added a comment to cover what I said on this thread, it is phrased
as cleanly as I could think of. I am more than happy to work on it
further if anyone has any suggestions to improve it.
Thanks,
Matthew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Re-work-setjmp-longjmp-to-match-o32-FPXX-and-FP64-AB.patch
Type: application/octet-stream
Size: 3350 bytes
Desc: 0001-Re-work-setjmp-longjmp-to-match-o32-FPXX-and-FP64-AB.patch
URL: <http://sourceware.org/pipermail/newlib/attachments/20141127/8ae3973e/attachment.obj>
More information about the Newlib
mailing list