[PATCH] Update newlib so that it passes libc++'s tests

Jonathan Roelofs jonathan@codesourcery.com
Mon Sep 22 15:52:00 GMT 2014



On 9/22/14 5:40 AM, Thomas Uhle wrote:
> On Fri, 2014-09-19 at 16:40 -0600, Jonathan Roelofs wrote:
>
>> (For context, here's the original thread:
>> https://sourceware.org/ml/newlib/2013/msg01077.html)
>>
>> I've rebased the remaining part of the original patch.  Please see the attached.
>> Is this good for commit, or does it still need work?
>>
>>
>> Cheers,
>> Jon
>>
>
> Hi Jon,
>
> your patch is missing an #endif
Good catch!
> and you would also have to replace every
>
>    (defined(__STDC_VERSION__) || __STDC_VERSION__ >= 199901L) || \
>
> by
>
>    (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) || \
Oh, yeah, you're right, another good point.
>
> to make it work correctly. However, your patch is part of the patch that
> I sent on September 9th and which is attached to this e-mail again.
Excellent. Here's a link to the thread to save other folks looking for it: 
https://sourceware.org/ml/newlib/2014/msg00418.html

With that, I'll yield to your patch's review as it subsumes mine.


Cheers,

Jon
>
> Best regards,
>
> Thomas Uhle
>

-- 
Jon Roelofs
jonathan@codesourcery.com
CodeSourcery / Mentor Embedded



More information about the Newlib mailing list