[PATCH] Update newlib so that it passes libc++'s tests
Jeff Johnston
jjohnstn@redhat.com
Mon Dec 23 21:22:00 GMT 2013
----- Original Message -----
> From: "JF Bastien" <jfb@chromium.org>
> To: "Jeff Johnston" <jjohnstn@redhat.com>
> Cc: "Craig Howland" <howland@lgsinnovations.com>, newlib@sourceware.org
> Sent: Friday, December 20, 2013 3:36:22 PM
> Subject: Re: [PATCH] Update newlib so that it passes libc++'s tests
>
> > As mentioned, if the libc++ test passes with an incremental fix, then I am
> > fine
> > with it. If it does not fix the libc++ test, then there is no impetus to
> > get a
> > partial fix in now and we can figure out a more correct solution.
> >
> > So, can you put together a patch that fixes the libc++ test, does not touch
> > stdint.h and is incrementally better for wchar.h?
>
> I'm currently traveling so testing things isn't as easy as it should be.
>
> IIRC the relevant test is test/depr/depr.c.headers/stdint_h.pass.cpp:
>
> // WCHAR_MIN
> assert(WCHAR_MIN == std::numeric_limits<wchar_t>::min());
>
> // WCHAR_MAX
> assert(WCHAR_MAX == std::numeric_limits<wchar_t>::max());
>
> Many other tests from libc++'s test suite will pass with an
> incremental fix, so it could still be a viable option, but I think
> this particular test won't pass.
>
Ok. I will delay the snapshot until you resubmit the patch. It passes additional
tests from libc++ so it is a step forward and we might as well make it part of the
snapshot.
I assume you will have this done by Monday.
-- Jeff J.
More information about the Newlib
mailing list