[PATCH] New targets for H8300H and H8300S Normal mode
J. Johnston
jjohnstn@redhat.com
Thu May 29 12:50:00 GMT 2003
Sorry for the delay. Patch has been checked in.
-- Jeff J.
Dhananjay R. Deshpande wrote:
>>Please explain the reasoning for your changes to libc/machine/h8300/setjmp.S.
>>You appear to have eliminated support for 32-bit ints (e.g. if a user passes
>>a value > 32767 to longjmp). You also have taken code that was common under one
>>#if and split it up without any changes.
>
>
>>-- Jeff J.
>
>
>
> Err. Sorry about that. That change is not intended but came from converting patch from 1.10.0 to 1.11.0 sources. The file setjmp.S has been changed and that patch is getting reverted.
>
> Thanks for pointing out this.
>
> Please find attached and inlined corrected patch.
>
> Regards,
> Dhananjay
>
> Newlib Changelog -
>
> 2003-05-09 Dhananjay Deshpande <dhananjayd@kpitcummins.com>
>
> * newlib/libc/machine/h8300/memcpy.S: Use .h8300hn and .h8300sn for
> normal mode
> * newlib/libc/machine/h8300/memset.S: Likewise
> * newlib/lib/machine/h8300/reg_memcpy.S: Likewise
> * newlib/lib/machine/h8300/reg_memset.S: Likewise
> * newlib/lib/machine/h8300/setjmp.S: Likewise
> * newlib/lib/machine/h8300/strcmp.S: Likewise
> * newlib/lib/sys/h8300hms/crt0.S: Likewise
>
> ==============================================================================
> diff -uprN newlib.old/libc/machine/h8300/memcpy.S newlib/libc/machine/h8300/memcpy.S
> --- newlib.old/libc/machine/h8300/memcpy.S Fri May 9 09:52:27 2003
> +++ newlib/libc/machine/h8300/memcpy.S Fri May 9 10:15:52 2003
> @@ -1,11 +1,19 @@
> #include "defines.h"
>
> #ifdef __H8300H__
> +#ifdef __NORMAL_MODE__
> + .h8300hn
> +#else
> .h8300h
> #endif
> +#endif
>
> #ifdef __H8300S__
> +#ifdef __NORMAL_MODE__
> + .h8300sn
> +#else
> .h8300s
> +#endif
> #endif
>
> .global _memcpy
> diff -uprN newlib.old/libc/machine/h8300/memset.S newlib/libc/machine/h8300/memset.S
> --- newlib.old/libc/machine/h8300/memset.S Fri May 9 09:52:27 2003
> +++ newlib/libc/machine/h8300/memset.S Fri May 9 10:15:52 2003
> @@ -1,11 +1,19 @@
> #include "defines.h"
>
> #ifdef __H8300H__
> +#ifdef __NORMAL_MODE__
> + .h8300hn
> +#else
> .h8300h
> #endif
> +#endif
>
> #ifdef __H8300S__
> +#ifdef __NORMAL_MODE__
> + .h8300sn
> +#else
> .h8300s
> +#endif
> #endif
>
>
> diff -uprN newlib.old/libc/machine/h8300/reg_memcpy.S newlib/libc/machine/h8300/reg_memcpy.S
> --- newlib.old/libc/machine/h8300/reg_memcpy.S Fri May 9 09:52:27 2003
> +++ newlib/libc/machine/h8300/reg_memcpy.S Fri May 9 10:15:52 2003
> @@ -1,11 +1,19 @@
> #include "defines.h"
>
> #ifdef __H8300H__
> +#ifdef __NORMAL_MODE__
> + .h8300hn
> +#else
> .h8300h
> #endif
> +#endif
>
> #ifdef __H8300S__
> +#ifdef __NORMAL_MODE__
> + .h8300sn
> +#else
> .h8300s
> +#endif
> #endif
>
>
> diff -uprN newlib.old/libc/machine/h8300/reg_memset.S newlib/libc/machine/h8300/reg_memset.S
> --- newlib.old/libc/machine/h8300/reg_memset.S Fri May 9 09:52:27 2003
> +++ newlib/libc/machine/h8300/reg_memset.S Fri May 9 10:15:52 2003
> @@ -1,11 +1,19 @@
> #include "defines.h"
>
> #ifdef __H8300H__
> +#ifdef __NORMAL_MODE__
> + .h8300hn
> +#else
> .h8300h
> #endif
> +#endif
>
> #ifdef __H8300S__
> +#ifdef __NORMAL_MODE__
> + .h8300sn
> +#else
> .h8300s
> +#endif
> #endif
>
>
> diff -uprN newlib.old/libc/machine/h8300/setjmp.S newlib/libc/machine/h8300/setjmp.S
> --- newlib.old/libc/machine/h8300/setjmp.S Fri May 9 09:52:27 2003
> +++ newlib/libc/machine/h8300/setjmp.S Fri May 9 10:15:17 2003
> @@ -1,11 +1,19 @@
> .file "setjmp.S"
>
> #ifdef __H8300H__
> +#ifdef __NORMAL_MODE__
> + .h8300hn
> +#else
> .h8300h
> #endif
> +#endif
>
> #ifdef __H8300S__
> +#ifdef __NORMAL_MODE__
> + .h8300sn
> +#else
> .h8300s
> +#endif
> #endif
>
> .section .text
> diff -uprN newlib.old/libc/machine/h8300/strcmp.S newlib/libc/machine/h8300/strcmp.S
> --- newlib.old/libc/machine/h8300/strcmp.S Fri May 9 09:52:27 2003
> +++ newlib/libc/machine/h8300/strcmp.S Fri May 9 10:15:52 2003
> @@ -1,11 +1,19 @@
> #include "defines.h"
>
> #ifdef __H8300H__
> +#ifdef __NORMAL_MODE__
> + .h8300hn
> +#else
> .h8300h
> #endif
> +#endif
>
> #ifdef __H8300S__
> +#ifdef __NORMAL_MODE__
> + .h8300sn
> +#else
> .h8300s
> +#endif
> #endif
>
> .section .text
> diff -uprN newlib.old/libc/sys/h8300hms/crt0.S newlib/libc/sys/h8300hms/crt0.S
> --- newlib.old/libc/sys/h8300hms/crt0.S Fri May 9 09:52:27 2003
> +++ newlib/libc/sys/h8300hms/crt0.S Fri May 9 10:15:52 2003
> @@ -30,7 +30,11 @@ _stack: .word 1
>
> #ifdef __H8300H__
>
> +#ifdef __NORMAL_MODE__
> + .h8300hn
> +#else
> .h8300h
> +#endif
> .section .text
> .global _start
> _start:
> @@ -58,8 +62,11 @@ _stack: .long 1
> #endif
>
> #ifdef __H8300S__
> -
> +#ifdef __NORMAL_MODE__
> + .h8300sn
> +#else
> .h8300s
> +#endif
> .section .text
> .global _start
> _start:
> ==============================================================================
More information about the Newlib
mailing list