your patch broke darwin libffi

Andreas Tobler toa@pop.agri.ch
Sat Jan 19 05:54:00 GMT 2002



Bryce McKinlay wrote:
> 
> David Edelsohn wrote:
> 
> >>>>>>Bryce McKinlay writes:
> >>>>>>
> >
> >Bryce> Wouldn't it be better to give this function the same name in both aix.S
> >Bryce> and darwin.S, since only one of them gets built?
> >
> >       I was trying to add the support with as little intrusion as
> >necessary while utilizing the similarities.  Darwin is not AIX and AIX is
> >not Darwin.  What name would you suggest?  During our last discussion, no
> >one could find a common name.
> >
> 
> I don't see any reason why the platform/ABI name has to be in the
> function name. How about simply ffi_call_inner or ffi_call_asm?

What about this one? It works on my darwin book, does it work with AIX
as well David?
Does it make sense? Would it be worth to go one step further and replace
the ffi_call_SYSV as well?

Regards,
Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libffi.patch
Type: application/octet-stream
Size: 3562 bytes
Desc: Document
URL: <http://sourceware.org/pipermail/libffi-discuss/attachments/20020119/c6e07ce2/attachment.obj>


More information about the Libffi-discuss mailing list