☠ Buildbot (Sourceware): glibc-autoregen - failed 'git diff ...' (failure) (master)

[Collin Funk]

Hi Mark,

Mark Wielaard <mark@klomp.org> writes:

> Note that we currently use gperf 3.1, but gperf 3.2[.1] seems to
> already have support for more modern "implicit fallthrough" warnings
> in 'switch' statements.
>
> 3.2.1 generates:
>
> #if (defined __cplusplus && (__cplusplus >= 201703L || (__cplusplus >= 201103L && defined __clang__ && __clang_major__ + (__clang_minor__ >= 9) > 3))) || (defined __STDC_VERSION__ && __STDC_VERSION__ >= 202000L && ((defined __GNUC__ && __GNUC__ >= 10) || (defined __clang__ && __clang_major__ >= 9)))
>        [[fallthrough]];
> #elif (defined __GNUC__ && __GNUC__ >= 7) || (defined __clang__ && __clang_major__ >= 10)
>       __attribute__ ((__fallthrough__));
> #endif
>       /*FALLTHROUGH*/
>
> So maybe we should simply require people who regenerate these files to
> install gperf 3.2.1 (and also install that version on the buildbot?)

My idea after looking at the Makefile was just to pipe the output into
'sed', but perhaps it is better to let gperf deal with things for us.
The latest version is 3.3, is there any reason to prefer 3.2.1?

Thanks for the Wiki link by the way. I didn't know about that page.

Collin