Makerules:1196 include $(o-iterator)

[Adhemerval Zanella Netto]

On 30/10/25 04:22, Dmitry via Libc-help wrote:
> Hello, I see the following lines in Makerules:
> 
> 1194 # Handle tests-time64 and xtests-time64 that should built with LFS
> 1195 # and 64-bit time support.
> 1196 include $(o-iterator)
> 1197 define o-iterator-doit
> 1198 $(foreach f,$(tests-time64) $(xtests-time64),\
> 1199             $(objpfx)$(f)$(o)): CFLAGS += -D_TIME_BITS=64
> -D_FILE_OFFSET_BITS=64
> 1200 endef
> 1201 object-suffixes-left := $(all-object-suffixes)
> 1202 include $(o-iterator)
> 1203
> 
> What is the purpose of the include directive on line 1196?
> To use $(o-iterator), we must set o-iterator-doit and
> object-suffixes-left beforehand, but this is done for line 1202. The
> last definition of o-iterator-doit and object-suffixes-left occurs
> many lines earlier and applies to other includes.

The inclusion might be superfluous, if you remove it does the 64-bit
time_t flags are still applied for the tests?