[PATCH] PPC enable Alitvec hardware, part 1 revision a

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steve Munroe wrote:

> +++ libc23/sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h	2004-01-12 18:14:28.028147584 -0600
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 1998, 1999, 2002 Free Software Foundation, Inc.
> +/* Copyright (C) 1998, 1999, 2002, 2004 Free Software Foundation, Inc.
>     This file is part of the GNU C Library.
>  
>     The GNU C Library is free software; you can redistribute it and/or
> @@ -20,6 +20,7 @@
>  #define _SYS_UCONTEXT_H	1
>  
>  #include <features.h>
> +#include <kernel-features.h>
>  #include <signal.h>
>  
>  /* We need the signal context definitions even if they are not used
> @@ -29,7 +30,7 @@
>  #if __WORDSIZE == 32
>  
>  /* Number of general registers.  */
> -#define NGREG	48
> +# define NGREG	48
>  
>  /* Container for all general registers.  */
>  typedef unsigned long gregset_t[NGREG];
> @@ -62,8 +63,53 @@
>  
>  #else
>  
> -/* For 64-bit, a machine context is exactly a sigcontext.  */
> +# ifdef __ASSUME_ALTIVEC_SIGCONTEXT

This is bogus.  kernel-features.h is available for compiling glibc and
is not installed.  You simply cannot have such a construct in a public
header.  The definitions must be usable regardless of the kernel used.



> +struct vmx_sigcontext {
> +	unsigned long	_unused[4];
> +	int		signal;
> +	int		_pad0;
> +	unsigned long	handler;
> +	unsigned long	oldmask;
> +	struct pt_regs	*regs;
> +	elf_gregset_t	gp_regs;
> +	elf_fpregset_t	fp_regs;

Namespace violations.  I know we already have some, but this doesn't
mean we add more.  <sys/ucontext.h> is a standard header, look at POSIX
to see what prefixes/suffixes are reserved.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFABNDE2ijCOnn/RHQRAjKqAJ0bz6cJIIc4/ISMOdxvVCgiNPcG3gCfenmj
m/qF2p/AQB5wZqRxFN0vBmU=
=crhV
-----END PGP SIGNATURE-----