[PATCH v3] localedata: update LC_ADDRESS and LC_NAME for ko_KR

Arjun Shankar arjun@redhat.com
Wed Apr 29 18:03:11 GMT 2026


Hi Jiho,

Thanks for the v3!

> Update the South Korean (ko_KR) locale to reflect official standards:
> - LC_ADDRESS: Follow the Large-to-Small hierarchy (Country, Postcode,
>   City, Road, Recipient) as per Korea Post guidelines.
>   (https://www.koreapost.go.kr/kpost/subIndex/135.do?pSiteIdx=125)

OK. I double checked. The official example does not mention country
but putting it near the top is in line with the large-to-small
hierarchy.

> - LC_NAME: Follow the standard Korean order (Surname + Given Name)
>   without Western-style salutations or tabs.

OK.

>
>     * localedata/locales/ko_KR (LC_ADDRESS): Update postal_fmt.
>     * localedata/locales/ko_KR (LC_NAME): Update name_fmt to "%f%g".
>
> Signed-off-by: Jiho Lee <elmitash@gmail.com>

OK.

Reviewed-by: Arjun Shankar <arjun@redhat.com>

Full review below.

>  localedata/locales/ko_KR | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/localedata/locales/ko_KR b/localedata/locales/ko_KR
> index 38235ebf08..176c23aa92 100644
> --- a/localedata/locales/ko_KR
> +++ b/localedata/locales/ko_KR
> @@ -16,8 +16,8 @@ escape_char /
>  % Fax:
>  % Language: ko
>  % Territory: KR
> -% Revision: 1.1
> -% Date: 2000-11-09
> +% Revision: 1.2
> +% Date: 2026-02-19

OK. Non functional metadata update.

>  % Application: general
>  % Users: general
>
> @@ -43,6 +43,9 @@ escape_char /
>  %       Some cosmetic changes
>  % 2001-10-08: Won-kyu Park <wkpark@chem.skku.ac.kr>
>  %       Fixed a typo in Hangul portion of LC_COLLATE
> +% 2026-02-19: Jiho Lee <elmitash@gmail.com>
> +%      Updated LC_ADDRESS to follow the modern South Korean address format
> +%      Update LC_NAME to the standard Korean order (Surname + Given Name)

OK.

>
>  LC_IDENTIFICATION
>  title      "Korean locale for Republic of Korea"
> @@ -54,8 +57,8 @@ tel        ""
>  fax        ""
>  language   "Korean"
>  territory  "South Korea"
> -revision   "1.1"
> -date       "2000-11-09"
> +revision   "1.2"
> +date       "2026-02-19"

OK. Matches earlier.

>
>  category "i18n:2012";LC_IDENTIFICATION
>  category "i18n:2012";LC_CTYPE
> @@ -6220,11 +6223,12 @@ copy "i18n"
>  END LC_MEASUREMENT
>
>  LC_NAME
> -name_fmt    "%d%t%g%t%m%t%f"
> +name_fmt    "%f%g"

OK. Apart from your explanation, I confirmed via a web search that
Korean names are regularly written this way without space.

>  END LC_NAME
>
>  LC_ADDRESS
> -postal_fmt    "%f%N%a%N%d%N%b%N%s %h %e %r%N%z %T%N%c%N"
> +postal_fmt    "%c%N%S %T %l %s %h%N%b %e %r%N%f %d%N%n %a%N%z"

OK. Matches the format from the website mentioned in the commit
message. The Country is an addition, but its positioning looks like in
line with the large-to-small order.

> +

Stray newline? I'll allow it :) we can avoid a v4!

>  country_name "대한민국"
>  country_ab2 "KR"
>  country_ab3 "KOR"
> --
> 2.54.0
>



More information about the Libc-alpha mailing list