[PATCH 1/2] misc: fix lint-makefiles failures

DJ Delorie dj@redhat.com
Fri Apr 17 19:39:40 GMT 2026


Yury Khrustalev <yury.khrustalev@arm.com> writes:
>  ifeq ($(subdir),elf)
> -sysdep-rtld-routines += dl-start
> -sysdep-dl-routines += tlsdesc dl-tlsdesc
> +sysdep-rtld-routines += \
> +  dl-start \
> +  # sysdep-rtld-routines
> +sysdep-dl-routines += \
> +  dl-tlsdesc \
> +  tlsdesc \
> +  # sysdep-dl-routines
>  gen-as-const-headers += \
>    dl-link.sym \
> -  rtld-global-offsets.sym
> +  rtld-global-offsets.sym \
> +  # gen-as-const-headers

Ok.

> -tests += tst-vpcs
> -modules-names += tst-vpcs-mod
> +tests += \
> +  tst-vpcs \
> +  # tests
> +modules-names += \
> +  tst-vpcs-mod \
> +  # modules-names

Ok.

>  ifeq ($(subdir),csu)
>  gen-as-const-headers += \
> +  rtld-global-offsets.sym \
>    tlsdesc.sym \
> -  rtld-global-offsets.sym
> +  # gen-as-const-headers
>  endif

Ok.

>  ifeq ($(subdir),misc)
> -sysdep_headers += sys/ifunc.h
> +sysdep_headers += \
> +  sys/ifunc.h \
> +  # sysdep_headers
>  sysdep_routines += \
> -  __mtag_tag_zero_region \
> -  __mtag_tag_region \
> +  __alloc_gcs \
>    __arm_za_disable \
> -  __alloc_gcs
> +  __mtag_tag_region \
> +  __mtag_tag_zero_region \
> +  # sysdep_routines

Ok.

>  ifeq ($(subdir),malloc)
> -sysdep_malloc_debug_routines = __mtag_tag_zero_region __mtag_tag_region
> +sysdep_malloc_debug_routines += \

This changes "=" to "+=".  Are you sure?  This macro is set in aarch64/
and generic/ Makefiles.  I think it's OK and consistent with the others,
but...

> +  __mtag_tag_region \
> +  __mtag_tag_zero_region \
> +  # sysdep_malloc_debug_routines
>  endif # malloc directory

>  ifeq ($(subdir),string)
> -sysdep_routines += tls-internal
> +sysdep_routines += \
> +  tls-internal \
> +  # sysdep_routines

Ok.

>  ifeq ($(subdir),elf)
>  ifeq ($(enable-gsframe),yes)
> -sysdep_routines += sframe-read sframe
> +sysdep_routines += \
> +  sframe-read sframe \

split these onto separate lines?

> +  # sysdep_routines

>  ifeq (yes:yes,$(build-shared):$(unwind-find-fde))
>  # This is needed to support g++ v2 and v3.
> -sysdep_routines += framestate unwind-pe
> -shared-only-routines += framestate unwind-pe
> +sysdep_routines += \
> +  framestate unwind-pe \
> +  # sysdep_routines
> +shared-only-routines += \
> +  framestate unwind-pe \
> +  # shared-only-routines
>  endif

Ok.

>  ifeq ($(subdir),malloc)
> -sysdep_malloc_debug_routines += hugepages
> +sysdep_malloc_debug_routines += \
> +  hugepages \
> +  # sysdep_malloc_debug_routines
>  endif

Ok.

>  ifeq ($(subdir),misc)
> -sysdep_routines += hugepages
> +sysdep_routines += \
> +  hugepages \
> +  # sysdep_routines
>  endif

Ok.



More information about the Libc-alpha mailing list