[PATCH 1/2] misc: fix lint-makefiles failures

[H.J. Lu]

On Thu, Apr 16, 2026 at 5:28 PM Yury Khrustalev <yury.khrustalev@arm.com>
wrote:
>
> ---
>  sysdeps/aarch64/Makefile | 39 ++++++++++++++++++++++++++++-----------
>  sysdeps/generic/Makefile | 24 ++++++++++++++++++------
>  2 files changed, 46 insertions(+), 17 deletions(-)
>
> diff --git a/sysdeps/aarch64/Makefile b/sysdeps/aarch64/Makefile
> index d6c5cc96ca..eecc4ad445 100644
> --- a/sysdeps/aarch64/Makefile
> +++ b/sysdeps/aarch64/Makefile
> @@ -31,11 +31,17 @@ tst-audit27-ENV = LD_AUDIT=$(objpfx)tst-auditmod27.so
>  endif
>
>  ifeq ($(subdir),elf)
> -sysdep-rtld-routines += dl-start
> -sysdep-dl-routines += tlsdesc dl-tlsdesc
> +sysdep-rtld-routines += \
> +  dl-start \
> +  # sysdep-rtld-routines
> +sysdep-dl-routines += \
> +  dl-tlsdesc \
> +  tlsdesc \
> +  # sysdep-dl-routines
>  gen-as-const-headers += \
>    dl-link.sym \
> -  rtld-global-offsets.sym
> +  rtld-global-offsets.sym \
> +  # gen-as-const-headers
>
>  tests-internal += \
>    tst-ifunc-arg-1 \
> @@ -44,16 +50,21 @@ tests-internal += \
>    tst-ifunc-arg-4 \
>    # tests-internal
>
> -tests += tst-vpcs
> -modules-names += tst-vpcs-mod
> +tests += \
> +  tst-vpcs \
> +  # tests
> +modules-names += \
> +  tst-vpcs-mod \
> +  # modules-names
>  LDFLAGS-tst-vpcs-mod.so = -Wl,-z,lazy
>  $(objpfx)tst-vpcs: $(objpfx)tst-vpcs-mod.so
>  endif
>
>  ifeq ($(subdir),csu)
>  gen-as-const-headers += \
> +  rtld-global-offsets.sym \
>    tlsdesc.sym \
> -  rtld-global-offsets.sym
> +  # gen-as-const-headers
>  endif
>
>  ifeq ($(subdir),gmon)
> @@ -65,12 +76,15 @@ CPPFLAGS += -I../soft-fp
>  endif
>
>  ifeq ($(subdir),misc)
> -sysdep_headers += sys/ifunc.h
> +sysdep_headers += \
> +  sys/ifunc.h \
> +  # sysdep_headers
>  sysdep_routines += \
> -  __mtag_tag_zero_region \
> -  __mtag_tag_region \
> +  __alloc_gcs \
>    __arm_za_disable \
> -  __alloc_gcs
> +  __mtag_tag_region \
> +  __mtag_tag_zero_region \
> +  # sysdep_routines
>
>  tests += \
>    tst-sme-jmp \
> @@ -88,5 +102,8 @@ $(objpfx)tst-sme-clone3: $(objpfx)clone3.o
$(objpfx)__arm_za_disable.o
>  endif
>
>  ifeq ($(subdir),malloc)
> -sysdep_malloc_debug_routines = __mtag_tag_zero_region __mtag_tag_region
> +sysdep_malloc_debug_routines += \
> +  __mtag_tag_region \
> +  __mtag_tag_zero_region \
> +  # sysdep_malloc_debug_routines
>  endif # malloc directory
> diff --git a/sysdeps/generic/Makefile b/sysdeps/generic/Makefile
> index 53c4efa63e..c34b113e61 100644
> --- a/sysdeps/generic/Makefile
> +++ b/sysdeps/generic/Makefile
> @@ -16,25 +16,37 @@
>  # <https://www.gnu.org/licenses/>.
>
>  ifeq ($(subdir),string)
> -sysdep_routines += tls-internal
> +sysdep_routines += \
> +  tls-internal \
> +  # sysdep_routines
>  CFLAGS-wordcopy.c += -Wno-uninitialized
>  endif
>
>  ifeq ($(subdir),elf)
>  ifeq ($(enable-gsframe),yes)
> -sysdep_routines += sframe-read sframe
> +sysdep_routines += \
> +  sframe-read sframe \
> +  # sysdep_routines
>  endif
>  ifeq (yes:yes,$(build-shared):$(unwind-find-fde))
>  # This is needed to support g++ v2 and v3.
> -sysdep_routines += framestate unwind-pe
> -shared-only-routines += framestate unwind-pe
> +sysdep_routines += \
> +  framestate unwind-pe \
> +  # sysdep_routines
> +shared-only-routines += \
> +  framestate unwind-pe \
> +  # shared-only-routines
>  endif
>  endif
>
>  ifeq ($(subdir),malloc)
> -sysdep_malloc_debug_routines += hugepages
> +sysdep_malloc_debug_routines += \
> +  hugepages \
> +  # sysdep_malloc_debug_routines
>  endif
>
>  ifeq ($(subdir),misc)
> -sysdep_routines += hugepages
> +sysdep_routines += \
> +  hugepages \
> +  # sysdep_routines
>  endif
> --
> 2.47.3
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.

-- 
H.J.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20260416/e5ce3631/attachment.htm>