[PATCH] nss: Group merge does not react to ERANGE during merge (bug 33361)

[Collin Funk]

Florian Weimer <fw@deneb.enyo.de> writes:

> * Collin Funk:
>
>> The existing code seems unintentional, since the status would likely
>> (certainly?) be overwritten by another call to DL_CALL_FCT. Is that what
>> the user experienced?
>
> I assume you mean the service module function, not DL_CALL_FCT (which
> just a wrapper for profiling accounting, usually a no-op).
>
> Yes, if the loop iterates once more, than the status gets overwritten,
> and the caller (eventually, the application) does not see the ERANGE.

Okay, makes sense. The macros were a bit hard to follow. :)

>> Actually, you might want to hold off on this. I get the following test
>> failures:
>>
>>     FAIL: nss/tst-nss-files-hosts-long
>>     FAIL: stdio-common/tst-setvbuf2
>>
>> I doubt tst-setvbuf2 is related, but I'll have to look into the other
>> one.
>
> Both are likely test timeouts, unrelated to the change.

Upon retrying, tst-nss-files-hosts-long passes. tst-setvbuf2 still
fails, but it fails even on a commit I recall it passing. Likely a
problem with my environment that I will have to investigate.

So I think this commit is good to push, thanks.

Collin