[PATCH v7] libio: Add test case for fflush
Joseph Myers
josmyers@redhat.com
Thu Apr 10 17:34:02 GMT 2025
On Thu, 10 Apr 2025, Carlos O'Donell wrote:
> Joseph,
>
> May we please get a "Reviewed-by:" from you to record in the git commit
> history?
Reviewed-by: Joseph Myers <josmyers@redhat.com>
> In particularly I like "Reviewed-by:" because it is an unambiguous statement
> of
> the completion of review. While "This version is OK." can be seen to mean the
> same thing, I would like us to:
>
> (a) Allow new members of the community to have a clear indicator of
> "review is done and you can push."
>
> (b) Be able to thank you at the release for your efforts in reviewing :-)
Being useful for (a) renders Reviewed-by of only very limited value for
(b), since it provides no way to acknowledge the value of reviews that
*don't* say the patch is now ready to push (not necessarily by the same
person giving final approval).
--
Joseph S. Myers
josmyers@redhat.com
More information about the Libc-alpha
mailing list