[PATCH v7] libio: Add test case for fflush
Carlos O'Donell
carlos@redhat.com
Thu Apr 10 17:29:09 GMT 2025
On 4/10/25 12:18 PM, Joseph Myers wrote:
> On Thu, 10 Apr 2025, Frédéric Bérat wrote:
>
>> Hello,
>>
>> This patch adds a test to verify that `fflush (FILE)` and `fflush (NULL)` are
>> semantically equivalent from the FILE perspective, which currently fails if the
>> file is opened with read mode.
>
> This version is OK.
>
Joseph,
May we please get a "Reviewed-by:" from you to record in the git commit history?
In particularly I like "Reviewed-by:" because it is an unambiguous statement of
the completion of review. While "This version is OK." can be seen to mean the
same thing, I would like us to:
(a) Allow new members of the community to have a clear indicator of
"review is done and you can push."
(b) Be able to thank you at the release for your efforts in reviewing :-)
--
Cheers,
Carlos.
More information about the Libc-alpha
mailing list