[PATCH] powerpc: Remove power8 strcasestr optimization

Peter Bergner bergner@linux.ibm.com
Fri Mar 15 19:57:13 GMT 2024


I'm sorry I haven't replied earlier, but I just got back from vacation.
I also see you've pushed this already.  That said...

As with the power7 patch, I'm all for cleanups, especially if they
simplify things, remove more code than they add, and make things
faster.


On 3/5/24 2:13 PM, Adhemerval Zanella wrote:
> Similar to strstr (1e9a550ba4), power8 strcasestr does not show much
> improvement compared to the generic implementation.  The geomean
> on bench-strcasestr shows:
> 
>             __strcasestr_power8  __strcasestr_ppc
>   power10                  1159              1120
>   power9                   1640              1469
>   power8                   1787              1904

The generic implementation being the one in string/strcasestr.c,
correct?  Then how do I read the performance numbers above?

When Raji first added the power8 optimized routine, it was
showing big speedups.  I see that was before Wilco's changes
to the generic routine.  Do you think that was the main
reason why the generic implementation is better now?


Even though it's already pushed...

LGTM.

Reviewed-by: Peter Bergner <bergner@linux.ibm.com>  

Peter




More information about the Libc-alpha mailing list