[PATCH] powerpc: Remove power8 strcasestr optimization

DJ Delorie dj@redhat.com
Tue Mar 12 02:37:15 GMT 2024


Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/Makefile b/sysdeps/powerpc/powerpc64/multiarch/Makefile
> -		   strlen-power8 strcasestr-power8 strcasestr-ppc64 \
> +		   strlen-power8 \

Removing strcasestr-power8 and strcasestr-ppc64, ok.

> diff --git a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> index e3e6f5fd10..30fd89e109 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c
> @@ -432,14 +432,5 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
>               IFUNC_IMPL_ADD (array, i, strcspn, 1,
>                               __strcspn_ppc))
>  
> -  /* Support sysdeps/powerpc/powerpc64/multiarch/strcasestr.c.  */
> -  IFUNC_IMPL (i, name, strcasestr,
> -	      IFUNC_IMPL_ADD (array, i, strcasestr,
> -			      hwcap2 & PPC_FEATURE2_ARCH_2_07
> -			      && hwcap & PPC_FEATURE_HAS_ALTIVEC,
> -			      __strcasestr_power8)
> -             IFUNC_IMPL_ADD (array, i, strcasestr, 1,
> -                             __strcasestr_ppc))
> -

We're removing all of the three implementations, so ok.

> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S b/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr-ppc64.c b/sysdeps/powerpc/powerpc64/multiarch/strcasestr-ppc64.c
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr.c b/sysdeps/powerpc/powerpc64/multiarch/strcasestr.c
> deleted file mode 100644

Ok.

> diff --git a/sysdeps/powerpc/powerpc64/power8/Makefile b/sysdeps/powerpc/powerpc64/power8/Makefile
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr-ppc64.c b/sysdeps/powerpc/powerpc64/power8/strcasestr-ppc64.c
> deleted file mode 100644
> diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr.S b/sysdeps/powerpc/powerpc64/power8/strcasestr.S
> deleted file mode 100644

Ok.

LGTM

Reviewed-by: DJ Delorie <dj@redhat.com>



More information about the Libc-alpha mailing list