[PATCH v6 5/9] nptl: Remove g_refs from condition variables

Malte Skarupke malteskarupke@fastmail.fm
Sat Dec 7 21:17:10 GMT 2024


Am Do, 5. Dez 2024, um 03:30, schrieb Florian Weimer:
> This looks like an unnecessary change to the on-disk layout.  Shouldn't
> we keep the field as __g_refs_unused for now?
>
> Thanks,
> Florian

In a previous version I had tried to keep the sizes the same, but then got this comment which told me that I shouldn't bother because this struct doesn't actually determine the size:

https://www.sourceware.org/bugzilla/show_bug.cgi?id=25847#c64

Quotes:
> The size of the public condvar structure is always maintained by the top-level union (which takes into consideration the old linuxthreads implementation size):

...

> We don't even need an __unused here.


More information about the Libc-alpha mailing list