[PATCH v6 5/9] nptl: Remove g_refs from condition variables

Florian Weimer fweimer@redhat.com
Thu Dec 5 08:30:07 GMT 2024


* Carlos O'Donell:

> diff --git a/sysdeps/nptl/bits/thread-shared-types.h b/sysdeps/nptl/bits/thread-shared-types.h
> index df54eef6f7..a3d482f80f 100644
> --- a/sysdeps/nptl/bits/thread-shared-types.h
> +++ b/sysdeps/nptl/bits/thread-shared-types.h
> @@ -95,8 +95,7 @@ struct __pthread_cond_s
>  {
>    __atomic_wide_counter __wseq;
>    __atomic_wide_counter __g1_start;
> -  unsigned int __g_refs[2] __LOCK_ALIGNMENT;
> -  unsigned int __g_size[2];
> +  unsigned int __g_size[2] __LOCK_ALIGNMENT;
>    unsigned int __g1_orig_size;
>    unsigned int __wrefs;
>    unsigned int __g_signals[2];

This looks like an unnecessary change to the on-disk layout.  Shouldn't
we keep the field as __g_refs_unused for now?

Thanks,
Florian



More information about the Libc-alpha mailing list